Skip to content

Add Felix prometheus metrics for latency behind Typha#10918

Draft
fasaxc wants to merge 3 commits intoprojectcalico:masterfrom
fasaxc:typha-latency
Draft

Add Felix prometheus metrics for latency behind Typha#10918
fasaxc wants to merge 3 commits intoprojectcalico:masterfrom
fasaxc:typha-latency

Conversation

@fasaxc
Copy link
Member

@fasaxc fasaxc commented Sep 3, 2025

Description

  • Typha sends a breadcrumb revision message to felix.
  • Message plumbed through to the dataplane.
  • Dataplane updates a prometheus stat with the latency vs the message.

Related issues/PRs

CORE-11789

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Felix now reports the timestamp of the most recent update from Typha that has been fully applied to the dataplane as a Prometheus metric `felix_int_dataplane_last_typha_timestamp_seconds`. Typha now reports the timestamp of the most recent breadcrumb `typha_breadcrumb_timestamp` for comparison.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@marvin-tigera marvin-tigera added this to the Calico v3.31.0 milestone Sep 3, 2025
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Sep 3, 2025
@fasaxc fasaxc force-pushed the typha-latency branch 9 times, most recently from 6d83c3f to e455ccf Compare September 5, 2025 09:17
fasaxc added 3 commits October 6, 2025 15:15
- Typha sends a breadcrumb revision message to felix.
- Message plumbed through to the dataplane.
- Dataplane updates a prometheus stat with the latency vs the message.
- Annotate typha breadcrumb stats with server ID to allow comparison
  with Felix.
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Issues without recent activity label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) stale Issues without recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants