Skip to content

Rewrite slideshow to not have a jquery dependency - #234

Open
jcoyne wants to merge 1 commit into
mainfrom
no-jquery
Open

Rewrite slideshow to not have a jquery dependency#234
jcoyne wants to merge 1 commit into
mainfrom
no-jquery

Conversation

@jcoyne

@jcoyne jcoyne commented Mar 27, 2026

Copy link
Copy Markdown
Member

No description provided.

@jcoyne
jcoyne force-pushed the no-jquery branch 3 times, most recently from e99a2c7 to 8a82681 Compare March 27, 2026 17:33
Comment thread app/javascript/blacklight-gallery/slideshow.js Outdated
@marlo-longley

marlo-longley commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

@jcoyne not sure if you can reproduce this but I am getting an error.

  1. Go to a slideshow view http://localhost:3000/?f%5Bpub_date_ssim%5D%5B%5D=2008&view=slideshow
Screenshot 2026-03-27 at 3 07 35 PM
  1. Click the first item to open modal ("California", all the way to the left)
  2. Result: broken view in modal (vert scrolling all the items)
Screenshot 2026-03-27 at 3 04 32 PM 4. Now click the next arrow, or X out of the modal and open it again
  1. Result: correct single-item view in modal, including when you page back to the first item
Screenshot 2026-03-27 at 3 10 16 PM

@jcoyne

jcoyne commented Mar 27, 2026

Copy link
Copy Markdown
Member Author

@marlo-longley that seems like stale code because we don't use .querySelector() in this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants