Skip to content

Remove :document argument for compatibility with BL9 DocumentComponent slots #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcoyne merged 1 commit into from
Oct 10, 2025
Merged

Remove :document argument for compatibility with BL9 DocumentComponent slots #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/components/blacklight/gallery/openseadragon_embed_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,19 @@
module Blacklight
module Gallery
class OpenseadragonEmbedComponent < Blacklight::Component
attr_reader :document, :presenter, :classes
attr_reader :presenter, :classes

def initialize(document:, presenter:, view_config: nil, classes: [], **kwargs)
super
def initialize(presenter:, view_config: nil, classes: [], **kwargs)
super()

@document = document
@presenter = presenter
@view_config = view_config
@classes = classes
@id_prefix = id_prefix
end

def image
@image ||= document.to_openseadragon(view_config)
@image ||= presenter.document.to_openseadragon(view_config)
end

def count
Expand Down
2 changes: 1 addition & 1 deletion app/views/catalog/_openseadragon_default.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<%= render Blacklight::Gallery::OpenseadragonEmbedComponent.new(document: document, presenter: document_presenter(document), view_config: local_assigns[:view_config], classes: [osd_container_class]) %>
<%= render Blacklight::Gallery::OpenseadragonEmbedComponent.new(presenter: document_presenter(document), view_config: local_assigns[:view_config], classes: [osd_container_class]) %>
1 change: 0 additions & 1 deletion spec/components/blacklight/gallery/openseadragon_embed_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
RSpec.describe Blacklight::Gallery::OpenseadragonEmbedComponent, type: :component do
subject(:component) do
described_class.new(
document: document,
presenter: presenter,
**attr
)
Expand Down