fix:Added aria description to EditableInput#3982
Open
Nishthajain7 wants to merge 1 commit intoprocessing:developfrom
Open
fix:Added aria description to EditableInput#3982Nishthajain7 wants to merge 1 commit intoprocessing:developfrom
Nishthajain7 wants to merge 1 commit intoprocessing:developfrom
Conversation
yugalkaushik
reviewed
Mar 8, 2026
| }`; | ||
| const inputRef = React.useRef(); | ||
| const { t } = useTranslation(); | ||
| const label = |
Contributor
There was a problem hiding this comment.
@Nishthajain7 Thanks for the PR. The changes look good overall and the refactoring around EditableInput makes the accessibility handling cleaner. One thing I am not completely sure about is the priority order in the label computation, can you search about it more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3936
Changes:
Added
aria-labeltoEditableInputin CollectionMetadata.jsx and ProjectName.jsx so that the screen reader can describe the input fieldI have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123