Refactor interface availability code#9
Merged
Dirbaio merged 2 commits intoprobe-rs:masterfrom Jan 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the interface availability code by replacing constant flags with dynamic function calls and a bitflags‑based approach to determine capabilities.
- Refactors the Swo trait and adds a NoSwo marker struct for cases with no SWO support.
- Replaces constant AVAILABLE definitions in SWD and JTAG traits with dynamic availability functions.
- Introduces a bitflags structure in the Dap module to streamline capability reporting and update related logic.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/swo.rs | Updated Swo trait to return booleans and added the NoSwo implementation. |
| src/swd.rs | Replaced constant availability with a function-based check. |
| src/mock_device.rs | Updated SWD and JTAG implementations to use function availability. |
| src/jtag.rs | Replaced constant availability with a function-based check. |
| src/dap.rs | Introduced bitflags to represent capabilities and refactored DAP logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #8 and enables bitbang-dap to set the correct capabilities based on how many pins the user provides to the constructor (in theory, unimplemented atm.).
The SWO changes allow users to: