Reviewing how and when we call cleanModifierInvocationArguments#1444
Merged
Reviewing how and when we call cleanModifierInvocationArguments#1444
cleanModifierInvocationArguments#1444Conversation
Janther
added
bug
Janther
force-pushed
the
clean-modifier-invocations
branch
from
0059d29 to
2cec6fb
Compare
Janther
force-pushed
the
clean-modifier-invocations
branch
from
2cec6fb to
1d5fd1e
Compare
fvictorio
approved these changes
Mar 8, 2026
Member
fvictorio
left a comment
fvictorio
left a comment
There was a problem hiding this comment.
I'm tempted to say we should drop support for solidity versions before 0.5.0 entirely, but for now let's keep supporting whichever versions Slang support, I guess. There's a tiny bit of value in that.
Member
Author
|
Yeah, I just meant to clean up the function calls and then I noticed that use case when cleaning up. which meant a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a few details to view here:
typeof attribute !== 'string'is obsolete.<0.5.0constructors where functions with the same name as the contract which is the reason for this being a public function, but we had forgotten that libraries can also invoke modifiers. I also added a test case for this scenario.