cleaning up how we check for TupleExpressions with a single item#1197
Merged
cleaning up how we check for TupleExpressions with a single item#1197
TupleExpressions with a single item#1197Conversation
…o we minimise the amount of chained accesses and as a bonus removing the non-null assertions
Janther
added
the
performance
Janther
force-pushed
the
exploring-tuples-with-single-expression
branch
from
295a97a to
d51cf49
Compare
Janther
commented
Jul 10, 2025
| @@ -24,9 +24,9 @@ function isEndOfChain( | |||
| path: AstPath<StrictAstNode> | |||
| ): boolean { | |||
| for ( | |||
Member
Author
There was a problem hiding this comment.
Here I'm just getting rid of the non-null assertions
fvictorio
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a tricky way to check if a
TupleExpressionhas a single item since aTupleValuecan have anExpressionor beundefined. However by the nature of aTupleExpressionif there is only 1TupleValue, then it will always have anExpression.This is very difficult to express in typescript therefor there are a few non-null assertions we were using.
To clean this I added a single function to
src/slang-nodes/TupleValues.tsto return the single expression contained. If it has multiple or 0 it will default toundefined.This avoids multiple checks and navigation down the chain like this
this.operand.variant.items.items[0].expression!