Merged
Conversation
c6ec971 to
4461a37
Compare
fvictorio
approved these changes
Jul 21, 2025
… into class attributes saving file size
…o need to destructure twice
…aner to have it as a constructor of a parent class and `updateMetadata` being a class function
4461a37 to
cae69e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses how we interact with the
getMetadata()andupdateMetadata()functions.Since every node calls these functions in order to retrieve the location information of the node and the comments contained by it.
All node files will have the same changes and the important changes are:
src/slang-nodes/SlangNode.tswhich from now on starts behaving as a base class for all nodes.src/slang-nodes/CommentNode.tswhich from now on starts behaving as a base class for all comments.src/slang-utils/metadata.tssince all of it's logic was moved intosrc/slang-nodes/SlangNode.tsas constructor or instance function.To check the progress step by step, here are the main changes to look at commit by commit:
src/slang-utils/metadata.tsandsrc/types.d.tssrc/slang-utils/metadata.tsandsrc/types.d.ts.src/slang-nodes/SlangNode.tsandsrc/slang-nodes/CommentNode.tsand removedsrc/slang-utils/metadata.ts.updateMetadatainsrc/slang-nodes/SlangNode.ts