Skip to content

avoid calling coerce multiple times and only do it once#1185

Merged
Janther merged 3 commits intomainfrom
compiler
Jul 21, 2025
Merged

avoid calling coerce multiple times and only do it once#1185
Janther merged 3 commits intomainfrom
compiler

Conversation

@Janther
Copy link
Copy Markdown
Member

@Janther Janther commented Jun 28, 2025

at the beginning of the parse.

Had to add an extra check in create-parser because the type grew in complexity.

@Janther Janther requested a review from fvictorio June 28, 2025 10:24
@Janther Janther added the performance Results in smaller size, better memory usage, or faster execution label Jun 28, 2025
@Janther
Copy link
Copy Markdown
Member Author

Janther commented Jul 10, 2025

Having second thoughts here as I'm not sure changing the compiler option's type and behaviour is worth the performance boost here.
Any thoughts @fvictorio ?
I'd have to further think about this one.

Update:
After some review I noticed that coerce is not needed at all since the compiler options will always be the Slang Language version, which is already a valid semver version and will not need a coercion.
I updated the PR accordingly.

@Janther Janther merged commit a782b28 into main Jul 21, 2025
7 checks passed
@Janther Janther deleted the compiler branch July 21, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Results in smaller size, better memory usage, or faster execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants