Sync Script and Mystery Event files with pokeruby#2234
Open
AsparagusEduardo wants to merge 3 commits intopret:masterfrom
Open
Sync Script and Mystery Event files with pokeruby#2234AsparagusEduardo wants to merge 3 commits intopret:masterfrom
AsparagusEduardo wants to merge 3 commits intopret:masterfrom
Conversation
Comment on lines
+22
to
+23
| // 0x1 in English FRLG, 0x2 in English RS, 0x4 in German RS | ||
| #define LANGUAGE_MASK 0x1 |
Member
There was a problem hiding this comment.
I'm a little confused about this one. Is it definitely a language value if it changes between versions with the same language?
Contributor
Author
There was a problem hiding this comment.
I'm a little confused about this one. Is it definitely a language value if it changes between versions with the same language?
right, that can't be... should I rename it to UNK_ME_MASK_1 or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Matching PR: pret/pokeruby#890
Discord contact info
AsparagusEduardo