Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors tmux command invocations to be more explicit and fixes a runner detection bug. The changes make the code more robust when working with both pane and window runner types.
- Simplified
VimuxTogglePane()to always uselast-paneinstead of dynamically choosing between pane/window - Refactored
VimuxZoomRunner()andVimuxInspectRunner()to work consistently for both pane and window types by explicitly switching client and selecting window/pane - Added public
VimuxHasRunner()function to expose runner status - Fixed
s:hasRunner()to use word boundary matching to prevent false positives in runner detection
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
I've tested this out in a couple different environments, the only thing I spotted that didn't work is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes several fixes to improve support for tracking the runner across windows and panes:
'%15'it previously would have reported that the runner exists even if it doesn't but a pane with index e.g.'%157'existed.VimuxHasRunner()function has been added.