fix: allow pixi config unset to remove unknown keys#5745
Open
mvanhorn wants to merge 1 commit intoprefix-dev:mainfrom
Open
fix: allow pixi config unset to remove unknown keys#5745mvanhorn wants to merge 1 commit intoprefix-dev:mainfrom
pixi config unset to remove unknown keys#5745mvanhorn wants to merge 1 commit intoprefix-dev:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
pixi config unsetencounters an unknown key (e.g., a deprecated config field), it now falls back to directly editing the TOML file instead of erroring. Known keys still go through the typedConfig::set()path.Why this matters
Per #5672, after
repodata-config.disable-jlapwas removed from the config struct, users get a warning about the unknown value butpixi config unset repodata-config.disable-jlaperrors becauseConfig::set()rejects unknown keys. Users should be able to remove any TOML key from their config file, especially deprecated ones.Changes
crates/pixi_cli/src/config.rs: ForAlterMode::Unset, tryconfig.set()first (for known keys), and on failure fall back to parsing the config file as atoml_edit::DocumentMut, walking the dotted key path, and removing the leaf key directly.remove_toml_key()helper for navigating dotted paths in TOML documents.Testing
cargo check -p pixi_clipasses. The fallback path handles:some-key)repodata-config.disable-jlap)Fixes #5672
This contribution was developed with AI assistance (Claude Code).