Skip to content

github-queries.js: declare constants as const#857

Merged
MakisH merged 2 commits intoprecice:masterfrom
praaatap:fix/global-variable-github-queries
Mar 17, 2026
Merged

github-queries.js: declare constants as const#857
MakisH merged 2 commits intoprecice:masterfrom
praaatap:fix/global-variable-github-queries

Conversation

@praaatap
Copy link
Contributor

Title

Remove var and use const, add semicolons

Description

This change enhances the JavaScript coding style and ensures the variables are safe.

Changes made

  1. Replaced var with const in variable declarations.
  2. Declared variables correctly instead of leaving them undeclared.
  3. Added missing semicolons to adhere to the standard JavaScript coding style.
  4. No functionality was altered. The code functionality is still the same.

Why this change

const is safer than var because it does not allow the variables to be reassigned by mistake.
Adding semicolons also enhances the code readability.

Summary

This commit only enhances code quality. It updates the coding style of the variables and formatting without altering the functionality of the program.

@MakisH MakisH added technical Technical issues on the website GSoC Contributed in the context of the Google Summer of Code labels Mar 16, 2026
@MakisH MakisH changed the title removed var let const added semicolon github-queries.js: declare constants as const Mar 17, 2026
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I resolved the conflicts.

This is rather trivial and does not affect functionality, but why not.

@MakisH MakisH merged commit b94d388 into precice:master Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC Contributed in the context of the Google Summer of Code technical Technical issues on the website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants