Core: bump serialize-javascript to 7.0.5 via npm override#14715
Open
patmmccann wants to merge 1 commit intomasterfrom
Open
Core: bump serialize-javascript to 7.0.5 via npm override#14715patmmccann wants to merge 1 commit intomasterfrom
patmmccann wants to merge 1 commit intomasterfrom
Conversation
Collaborator
Coverage Report for CI Build 24368156231Coverage decreased (-0.001%) to 96.342%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves two security alerts
Motivation
serialize-javascriptat6.0.2, so pinning to a 7.0.5+ release is required to resolve the older, potentially vulnerable version.Description
overridesentry inpackage.jsonto forceserialize-javascriptto^7.0.5across the dependency graph.【F:package.json†L167-L173】package-lock.jsonso the lockedserialize-javascriptpackage resolves to7.0.5and updated transitive references (notably undermochaandterser-webpack-plugin).【F:package-lock.json†L18926-L18934】【F:package-lock.json†L32837-L32837】【F:package-lock.json†L35265-L35270】package.jsonandpackage-lock.jsonto lock the new resolution.Testing
npm install --package-lock-onlywhich completed successfully.node -e "const lock=require('./package-lock.json'); console.log(lock.packages['node_modules/serialize-javascript'].version)"which prints7.0.5.npm ls serialize-javascript --alland confirmed the lockfile now resolvesserialize-javascriptto the overridden^7.0.5entry.Codex Task