Skip to content

MediaGo Bid Adapter: sends transactionId and Prebid.js version in the request payload, and optimizes deprecated navigator.platform#14538

Open
SylviaF wants to merge 9 commits intoprebid:masterfrom
SylviaF:master
Open

MediaGo Bid Adapter: sends transactionId and Prebid.js version in the request payload, and optimizes deprecated navigator.platform#14538
SylviaF wants to merge 9 commits intoprebid:masterfrom
SylviaF:master

Conversation

@SylviaF
Copy link
Contributor

@SylviaF SylviaF commented Mar 1, 2026

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  1. Transaction ID support: Added transactionId to the request payload, sourced from ortb2Imp.ext.tid or req.transactionId.
  2. Prebid version: Added pbjsversion: '$prebid.version$' to the request ext object for version tracking.
  3. OS field: Replaced deprecated navigator.platform with getDeviceOs(), which uses userAgentData.platform first, then navigator.platform, and finally getOsInfo() as a fallback.

Other information

@review-assignment-bot review-assignment-bot bot requested a review from gwhigs March 1, 2026 07:11
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 22538258973

Details

  • 11 of 14 (78.57%) changed or added relevant lines in 2 files are covered.
  • 46 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+33.2%) to 96.324%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/mediagoBidAdapter.js 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
src/adloader.js 9 76.92%
src/utils.js 37 90.51%
Totals Coverage Status
Change from base Build #3: 33.2%
Covered Lines: 217329
Relevant Lines: 225624

💛 - Coveralls


// Log transactionId for each imp (for debugging)
requestData.imp.forEach((imp, idx) => {
var tid = imp.ext && imp.ext.transactionId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its on imp.ext.tid not imp.ext.transactionid

}

/**
* 获取设备平台/操作系统,优先级:userAgentData.platform > navigator.platform > UA 解析
Copy link
Collaborator

@patmmccann patmmccann Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write comments in english as well; all of your comments must be in english and also in any language of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants