Core: add minWinningBidCacheTTL so winning bids don't expire (#12987)#14536
Core: add minWinningBidCacheTTL so winning bids don't expire (#12987)#14536vasujain00 wants to merge 1 commit intoprebid:masterfrom
Conversation
- Updated auction and auctionManager to utilize getEffectiveMinBidCacheTTL for determining bid TTL based on targeting status. - Added minWinningBidCacheTTL configuration to allow for differentiated TTL handling for winning bids. - Enhanced bidTTL module with new functions to support effective TTL calculations. - Updated tests to cover new TTL logic and configurations, ensuring correct behavior for bids with and without targeting set.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c06c4650ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ttl: (au) => au.end.then(() => { | ||
| const bids = au.getBidsReceived(); | ||
| if (bids.length === 0) { | ||
| const minTTL = getMinBidCacheTTL(); | ||
| return minTTL == null ? null : minTTL * 1000; |
There was a problem hiding this comment.
Refresh auction TTL when targeting status is updated
The auction-level TTL is computed once inside au.end.then(...), so it snapshots each bid’s status at auction end; however bids are marked BID_TARGETING_SET later via setStatusForBids when setTargetingForGPT runs. Because _auctions.refresh() is never triggered on that status transition, auctions can still expire using the pre-targeting TTL (for example minBidCacheTTL/bid TTL) instead of minWinningBidCacheTTL, which reintroduces the lazy-load renderAd/"cannot find ad" failure this change is trying to prevent when all bids have short TTLs.
Useful? React with 👍 / 👎.
|
@vasujain00 thanks for the feature! could you link a docs pull? |
Pull Request Test Coverage Report for Build 22521425597Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Hi, I am a little caught up in some tasks will review this tom. |
Summary
Adds
minWinningBidCacheTTLconfig option to prevent winning bids (that have had targeting set) from expiring, fixing "cannot find ad" / expired render errors when using GPT lazy load with scroll-based render.Problem
Setting
minBidCacheTTLcauses "cannot find ad" errors in lazy-load scenarios. The ad is fetched from GPT, but the scroll milestone for render takes a long time. Winning bids expire and are dropped from memory before GPT can render them.Solution
minWinningBidCacheTTL– When set, overridesminBidCacheTTLfor bids that have had targeting set (winning bids sent to the ad server).minBidCacheTTL).Infinity(or a large value) to effectively never expire winning bids.Usage
Changes
minWinningBidCacheTTLconfig,getMinWinningBidCacheTTL(), andgetEffectiveMinBidCacheTTL(bid)Testing
gulp lint– passedgulp test --file test/spec/auctionmanager_spec.js– 91 tests passedLabels
feature|minorFixes #12987