Skip to content

Linting: remove spacing exceptions#14531

Open
patmmccann wants to merge 7 commits intomasterfrom
chng-lint
Open

Linting: remove spacing exceptions#14531
patmmccann wants to merge 7 commits intomasterfrom
chng-lint

Conversation

@patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Feb 27, 2026 •
edited
Loading

removed a few spacing exceptions ,see #1111 . This should probably wait for prebid 11 to merge so as to not create conflicts

https://github.com/prebid/Prebid.js/pull/14531/changes#diff-a32a0887ed9d1d707bbb3b845b7df7fd40e673c47e7b60a3ebd896b68d3b8839

image

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator Author

patmmccann commented Feb 27, 2026

image

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 27, 2026
View reviewed changes
modules/performaxBidAdapter.js
return [{
method: 'POST',
url: ENDPOINT,
options: {'contentType': 'application/json'},
options: { 'contentType': 'application/json' },

Check warning

Code scanning / CodeQL

Application/json request type in bidder Warning

application/json request type triggers preflight requests and may increase bidder timeouts
modules/oguryBidAdapter.js

return {
method: 'POST',
url: BID_HOST,
data,
options: {contentType: 'application/json'},
options: { contentType: 'application/json' },

Check warning

Code scanning / CodeQL

Application/json request type in bidder Warning

application/json request type triggers preflight requests and may increase bidder timeouts
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/performaxBidAdapter.js (+2 errors)

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@monis0395 monis0395 monis0395 approved these changes

@dgirardi dgirardi Awaiting requested review from dgirardi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patmmccann @monis0395