Neuwo Rtd Module: Version v2.0.0 and Quality of Life Improvements by gregneuwo · Pull Request #14323 · prebid/Prebid.js

gregneuwo · 2026-01-09T13:03:46Z

Type of change

Description of change

Quality of Life Improvements

Add documentation for accessing Neuwo data via Prebid.js events
Implement concurrent bid request handling with pending promise sharing
Standardise log message format across module
Add _neuwo_prod=PrebidModule product identifier to API requests
Add tests for concurrent requests and product identifier
Add IAB taxonomy filtering documentation with configuration examples
Standardise code style

v2.0.0 – New API architecture

Migrate Neuwo RTD Module to a new API architecture
Maintain backward compatibility with legacy V1 endpoints
Introduce buildIabFilterConfig() and shared filtering logic
Refactor data processing and category injection to work across all tiers
Add unit tests for new API and legacy paths
Update documentation to reflect new API behaviour and configuration
Introduce Module versioning

v2.1.0 – OpenRTB 2.5 category fields

Add OpenRTB 2.5 category fields support (site.cat, site.sectioncat, site.pagecat, site.content.cat)
Extend integration example page to display OpenRTB 2.5 category fields
Update documentation with OpenRTB 2.5 examples and production build notes
Bump module version to 2.1.0

Other information

…le page

- Convert single quotes to double quotes for consistency - Format code with Prettier

- Add `// prettier-ignore` comment to preserve quoted keys in `IAB_CONTENT_TAXONOMY_MAP` - Apply Prettier formatting to *modules/neuwoRtdProvider.js*

…Neuwo RTD Module

Add optional filtering configuration for IAB Content and Audience taxonomies, allowing publishers to control the quantity and quality of categories injected into bid requests. - Add `iabTaxonomyFilters` parameter to module configuration for per-tier filtering - Implement `filterIabTaxonomyTier()` function to filter taxonomies by relevance threshold and limit count - Implement `filterIabTaxonomies()` function to apply filters across all tiers using tier key mapping - Add integration example checkbox to enable/disable filtering with hardcoded filter values

- Add test for API URL construction when `neuwoApiUrl` contains existing query parameters - Add tests for error response handling: 404 errors, pending request cleanup, and retry behaviour - Add tests for concurrent requests with errors ensuring all callbacks are invoked - Add tests for JSON parsing errors in success callback - Add test for retry after JSON parsing error - Add test for missing `marketing_categories` field in API response - Add test for sorting items with undefined/null relevance values - Reorganise test structure: nest caching, URL stripping, and filtering describes under main `getBidRequestData` block - Add documentation for generating test coverage reports with viewing instructions

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9dbdc600e0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

modules/neuwoRtdProvider.js

- Update `buildIabData()` to only include `id` in segment objects - Remove `label` requirement; segments now only need valid `ID` - Update documentation examples to reflect simplified segment structure - Update unit tests to match new segment format

…aintain backward compatibility - Add version 2.0.0 with multi-version IAB Content Taxonomy support - Implement automatic API capability detection from endpoint URL format - Maintain backward compatibility with legacy GET endpoints - Consolidate default IAB Content Taxonomy version to "2.2" constant - Transform legacy API responses to unified segtax-based format - Add `buildIabFilterConfig()` for filter configuration conversion - Add `transformV1ResponseToV2()` and `transformSegmentsV1ToV2()` helpers - Refactor `buildIabData()` to dynamically process all tiers - Update `injectIabCategories()` to work with unified response format - Enhance JSDoc documentation with format examples and API details - Add conditional logging for POST request bodies - Optimise filtering: apply once before caching for legacy endpoints

- Update all test mocks to use new segtax-based response format - Add tests for `buildIabFilterConfig()` function - Add tests for `injectIabCategories()` function - Add tests for `transformV1ResponseToV2()` function - Add tests for `transformSegmentsV1ToV2()` function - Update `buildIabData()` tests to use new tierData parameter structure - Add V1 API backward compatibility test suite with client-side filtering tests - Verify POST method and iabVersions query parameters for new API - Verify GET method and no iabVersions parameter for legacy V1 API - Update edge case tests for empty responses and error handling - Update integration tests for URL parameter handling with query strings - Remove hardcoded tier array constants (CONTENT_TIERS, AUDIENCE_TIERS)

- Change default IAB Content Taxonomy version from "3.0" to "2.2" - Add IAB Content Taxonomy version "1.0" to supported values list - Add server-side filtering explanation to IAB Taxonomy Filtering section - Update Available Tiers table to focus on taxonomy types instead of API internals - Add recommended configuration comments for `auctionDelay` and `waitForIt` - Update all configuration examples to use "2.2" as default taxonomy version - Remove "How it works" section

Add support for populating OpenRTB 2.5 category fields (`site.cat`, `site.sectioncat`, `site.pagecat`, `site.content.cat`) with IAB Content Taxonomy 1.0 segments. Changes: - Add `enableOrtb25Fields` configuration parameter (default: true) - Add `extractCategoryIds()` helper function to extract segment IDs from tier data - Refactor `buildIabData()` to use `extractCategoryIds()` for code reuse - Extend `buildIabFilterConfig()` to apply filters to IAB 1.0 when feature enabled - Modify `getBidRequestData()` to request IAB 1.0 data (segtax 1) when feature enabled - Add warning when feature enabled with legacy API endpoint - Extend `injectIabCategories()` to populate four OpenRTB 2.5 category fields - Update version to 2.1.0

Changes: - Add checkbox UI control for `enableOrtb25Fields` option (default: checked) - Add display section for OpenRTB 2.5 category fields data - Extract and display `site.cat`, `site.sectioncat`, `site.pagecat`, and `site.content.cat` fields - Update `bidRequested` event handler to capture category fields - Add localStorage persistence for `enableOrtb25Fields` setting - Pass `enableOrtb25Fields` parameter to module configuration

Changes: - Add 11 new `buildIabFilterConfig()` tests for OpenRTB 2.5 feature (enabled/disabled scenarios) - Add 11 new `extractCategoryIds()` tests covering all edge cases - Add 11 new `injectIabCategories()` tests for category field injection - Update 5 existing `buildIabFilterConfig()` tests - Add 6 new `getBidRequestData()` integration tests for V2 API with feature enabled/disabled - Move legacy API compatibility tests from V2 section to V1 section

…RTD Module Changes: - Add OpenRTB 2.5 feature description to module overview - Add `enableOrtb25Fields` parameter to parameters table - Add dedicated "OpenRTB 2.5 Category Fields" section with examples - Update ORTB2 data structure examples to show category fields - Add filtering section explaining IAB 1.0 filter application - Update "Accessing Neuwo Data" section with category field extraction example - Add "Building for Production" section with build command - Update segtax value in example (7 → 6) - Update version to 2.1.0

…ry params Replace POST request with GET and send IAB taxonomy filters as flattened URL query parameters instead of JSON body to avoid CORS preflight requests. Changes: - Replace `buildIabFilterConfig()` with `buildFilterQueryParams()` function - Change output from nested object to array of query parameter strings (e.g., `["filter_6_1_limit=3"]`) - Remove POST method and request body from ajax call - Add filter parameters directly to URL for /v1/iab endpoint - Maintain OpenRTB 2.5 filter application (ContentTier1/2 → segtax 1) - Update all unit tests to test `buildFilterQueryParams()` instead of `buildIabFilterConfig()` - Update tests expecting POST requests to expect GET requests - Update tests checking request body to check URL parameters - Update version to 2.2.0

coveralls · 2026-02-19T20:01:54Z

Pull Request Test Coverage Report for Build 22322939348

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

1467 of 1474 (99.53%) changed or added relevant lines in 2 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.02%) to 96.282%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/neuwoRtdProvider.js	191	192	99.48%
test/spec/modules/neuwoRtdProvider_spec.js	1276	1282	99.53%

Files with Coverage Reduction	New Missed Lines	%
modules/kinessoIdSystem.js	1	83.15%
test/spec/creative/crossDomainCreative_spec.js	1	93.75%
modules/concertAnalyticsAdapter.js	2	90.24%

Totals
Change from base Build 22149413522:	0.02%
Covered Lines:	213601
Relevant Lines:	221849

💛 - Coveralls

patmmccann · 2026-02-23T15:24:29Z

@gregneuwo they don't seem invalid to me

…tions - Replace global `cachedResponses` and `pendingRequests` singletons with objects keyed by `neuwoApiUrlFull` - Concurrent or sequential calls with different parameters (URL, taxonomy version, filters) maintain separate cache entries - Add LRU-style eviction capped at 10 entries to prevent unbounded cache growth - Log module version during `init()` - Add unit tests for cache isolation

gregneuwo · 2026-02-23T20:22:59Z

Keyed the cache by the full API URL (covers changed config params) to cover the case you mentioned. Is it good to go?

gregneuwo · 2026-02-26T06:50:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10f9221da6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

modules/neuwoRtdProvider.js

…limit: 0` to suppress tiers - Separate JSON parsing from response processing into distinct try/catch blocks - Add `Array.isArray` guard to `extractCategoryIds` - Only cache valid object responses so failed requests can be retried - Rename `isV2Api` to `isIabEndpoint` for clarity - Fix typo in log message and JSDoc (POST -> GET) - Bump to 2.2.1

gregneuwo · 2026-02-26T09:30:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f843e81b05

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

modules/neuwoRtdProvider.js

gregneuwo · 2026-02-26T10:22:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 266a56a22c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

modules/neuwoRtdProvider.js

…is 1.0

gregneuwo · 2026-02-26T10:38:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af53f6df21

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

modules/neuwoRtdProvider.js

gregneuwo · 2026-02-26T11:09:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00c5c32205

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

modules/neuwoRtdProvider.js

…omy is 1.0

gregneuwo · 2026-02-26T11:56:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 546357dbe6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

modules/neuwoRtdProvider.js

gregneuwo · 2026-02-26T12:03:55Z

@codex review

chatgpt-codex-connector · 2026-02-26T12:08:00Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

gregneuwo · 2026-02-26T13:03:14Z

@patmmccann All Codex feedback addressed across six review rounds, final review came back clean. The default IAB Content Taxonomy change from 3.0 to 2.2 (flagged P1 by Codex) is intentional: our clients consistently prefer 2.2 for their integrations, and any publisher needing 3.0 can still set it explicitly via iabContentTaxonomyVersion. CI failure is a Coveralls DNS outage. Is there anything else on our end before this can be merged?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 636a8c5ee9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-26T13:06:19Z

modules/neuwoRtdProvider.js


-  tiers.forEach((tier) => {
-    const tierData = marketingCategories?.[tier];
+  const { threshold, limit } = filter;


Guard null tier filters before destructuring

When a legacy endpoint response is processed with iabTaxonomyFilters containing a tier explicitly set to null (for example ContentTier1: null from merged config), filterIabTaxonomyTier() receives null and throws at destructuring (const { threshold, limit } = filter). That exception is caught in getBidRequestData() and causes the entire Neuwo payload to be discarded for the auction instead of just skipping that tier, so valid categories are lost. Treat non-object tier filters as {} before destructuring to avoid dropping all enrichment on this input shape.

Useful? React with 👍 / 👎.

grzgm added 13 commits December 17, 2025 12:45

feat: add live display and access examples of Neuwo API data to examp…

a1a5482

…le page

feat: add Prebid.js event timing tests to Neuwo RTD example page

729eb5d

style: standardize code style in Neuwo RTD example

a608817

- Convert single quotes to double quotes for consistency - Format code with Prettier

docs: add guide for accessing Neuwo RTD data outside Prebid.js

5be6d16

feat: add concurrent bid request handling to Neuwo RTD Module

25dc7ca

chore: standardize log message format in Neuwo RTD Module

710547c

feat: add product identifier to Neuwo API requests

f20ddc3

docs: fix typo in test file name in Neuwo RTD Module documentation

4a54cdc

style: format Neuwo RTD Module with Prettier

a2cba40

- Add `// prettier-ignore` comment to preserve quoted keys in `IAB_CONTENT_TAXONOMY_MAP` - Apply Prettier formatting to *modules/neuwoRtdProvider.js*

test: add coverage for concurrent requests and product identifier in …

aa3703c

…Neuwo RTD Module

docs: add IAB taxonomy filtering documentation to Neuwo RTD Module

8d60f80

review-assignment-bot bot requested a review from lksharma January 9, 2026 13:05

chatgpt-codex-connector bot reviewed Jan 9, 2026

View reviewed changes

modules/neuwoRtdProvider.js Outdated Show resolved Hide resolved

gregneuwo mentioned this pull request Jan 9, 2026

Neuwo Rtd Module: Version v2.0.0 and Quality of Life Improvements Documentation prebid/prebid.github.io#6384

Open

8 tasks

grzgm added 9 commits January 12, 2026 12:17

style: apply formatting to Neuwo RTD Module markdown documentation

e451de5

gregneuwo changed the title ~~Neuwo Rtd Module: Quality of life improvements and feautres~~ Neuwo Rtd Module: Version v2.0.0 and Quality of Life Improvements Jan 23, 2026

grzgm and others added 3 commits January 23, 2026 14:29

perf: change Content-Type to text/plain to avoid CORS preflight

79f1a3b

Merge branch 'master' into neuwo/quality-of-life-improvements

c2882bb

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

modules/neuwoRtdProvider.js Show resolved Hide resolved

modules/neuwoRtdProvider.js Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

modules/neuwoRtdProvider.js Outdated Show resolved Hide resolved

fix: isolate legacy endpoint cache keys by taxonomy version and filters

266a56a

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

modules/neuwoRtdProvider.js Show resolved Hide resolved

gregneuwo marked this pull request as draft February 26, 2026 10:32

fix: prevent duplicate filter query params when IAB Content Taxonomy …

af53f6d

…is 1.0

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

modules/neuwoRtdProvider.js Outdated Show resolved Hide resolved

modules/neuwoRtdProvider.js Outdated Show resolved Hide resolved

gregneuwo added 2 commits February 26, 2026 11:54

fix: only sort and filter taxonomy tiers when filter is configured

cfa194a

fix: detect /v1/iab endpoint from URL pathname instead of full string

00c5c32

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

modules/neuwoRtdProvider.js Outdated Show resolved Hide resolved

fix: prevent duplicate iabVersions=1 query param when content taxon…

546357d

…omy is 1.0

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

modules/neuwoRtdProvider.js Show resolved Hide resolved

Merge branch 'master' into neuwo/quality-of-life-improvements

636a8c5

gregneuwo marked this pull request as ready for review February 26, 2026 12:59

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

patmmccann approved these changes Feb 26, 2026

View reviewed changes

patmmccann merged commit a718fce into prebid:master Feb 26, 2026
101 of 102 checks passed

Conversation

gregneuwo commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Quality of Life Improvements

v2.0.0 – New API architecture

v2.1.0 – OpenRTB 2.5 category fields

Other information

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

coveralls commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 22322939348

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

patmmccann commented Feb 23, 2026

Uh oh!

gregneuwo commented Feb 23, 2026

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 26, 2026

Uh oh!

gregneuwo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

gregneuwo commented Jan 9, 2026 •

edited

Loading

coveralls commented Feb 19, 2026 •

edited

Loading