Bridgewell Bid Adapter: expand request data#14320
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4d64fae4c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
modules/bridgewellBidAdapter.js
Outdated
| const floorInfo = bid.getFloor?.() || {}; | ||
| adUnit.floor = floorInfo.floor; | ||
| adUnit.currency = floorInfo.currency; |
There was a problem hiding this comment.
Pass size/mediaType to getFloor for accurate floors
Calling bid.getFloor() with no parameters leaves mediaType/size as '*' unless the ad unit has exactly one media type and one size, because the floors helper only infers context in those narrow cases. For multi-size or multi-type ad units this will pick a wildcard floor instead of a size‑specific rule, so the adapter can send an incorrect floor (often lower) in those auctions. Consider passing {mediaType, size, currency} from the bid request to avoid missing targeted floor rules.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed. Now passing mediaType and size parameters to getFloor()
Type of change
Description of change
New Parameters Added to Bid Requests:
Core Auction Identifiers
auctionIdtransactionIdadUnitIdbidderRequestIdsrcPrebid Passthrough Data (
ortb2Imp.ext.prebid.passthrough)bucketclientgamAdCodegamLoccolodevicelangptregionsiteverAd Server & Placement Data (
ortb2Imp.ext.data)data.adserver.namedata.adserver.adslotdata.pbadslotgpidBanner Position
banner.posRequest Metadata
sizesbidderRequestsCountbidderWinsCountauctionsCountbidRequestsCountdeferBillingPerformance Metrics (
metrics)requestBids.usprequestBids.gpprequestBids.gdprrequestBids.priceFloorsrequestBids.rtdrequestBids.validaterequestBids.makeRequestsadapter.client.validateadapters.client.bridgewell.validateOpenRTB Site & Device Info (
ortb2)regs.gpp_sid,regs.gpp,regs.ext.gdpr,regs.ext.us_privacysite.domain,site.publisher.domain,site.page,site.content.languagedevice.w,device.h,device.dnt,device.ua,device.language,device.ext.vpw,device.ext.vph,device.suaPrice Floors
floorcurrency