Skip to content

Support nested createModel actions#906

Merged
JoviDeCroock merged 3 commits intomainfrom
fix-nested-model-actions
Mar 28, 2026
Merged

Support nested createModel actions#906
JoviDeCroock merged 3 commits intomainfrom
fix-nested-model-actions

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Member

Wrap nested object methods returned from createModel so composed models keep action batching semantics without manual action wrappers.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 9f6c4d7
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/69c787abd24c920008392c37
😎 Deploy Preview https://deploy-preview-906--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: 9f6c4d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@preact/signals-core Patch
preact-signals-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Size Change: +130 B (+0.07%)

Total Size: 177 kB

Filename Size Change
docs/dist/assets/bench-********.js 1.6 kB +3 B (+0.19%)
docs/dist/assets/devtools-********.js 913 B +4 B (+0.44%)
docs/dist/assets/EmbeddedDevtools-********.js 16.6 kB +29 B (+0.17%)
docs/dist/assets/index-********.js 1.09 kB -108 B (-8.99%)
docs/dist/assets/signals-core.module-********.js 1.89 kB +35 B (+1.89%)
docs/dist/assets/signals.module-********.js 2.64 kB +2 B (+0.08%)
docs/dist/assets/Unmount-********.js 652 B +3 B (+0.46%)
docs/dist/assets/utils.module-********.js 454 B +6 B (+1.34%)
docs/dist/basic-********.js 249 B +5 B (+2.05%)
docs/dist/nesting-********.js 1.15 kB +2 B (+0.17%)
docs/dist/react-********.js 243 B +1 B (+0.41%)
packages/core/dist/signals-core.js 1.92 kB +36 B (+1.91%)
packages/core/dist/signals-core.mjs 1.91 kB +40 B (+2.14%)
packages/devtools-ui/dist/devtools-ui.js 15.2 kB +37 B (+0.24%)
packages/devtools-ui/dist/devtools-ui.mjs 14.7 kB +35 B (+0.24%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client-********.js 46.6 kB
docs/dist/assets/jsxRuntime.module-********.js 300 B
docs/dist/assets/preact.module-********.js 4.74 kB
docs/dist/assets/style-********.css 5.26 kB
packages/debug/dist/debug.js 4.58 kB
packages/debug/dist/debug.mjs 4.09 kB
packages/devtools-adapter/dist/devtools-adapter.js 2.17 kB
packages/devtools-adapter/dist/devtools-adapter.mjs 1.88 kB
packages/preact-transform/dist/signals-transform.js 1.3 kB
packages/preact-transform/dist/signals-transform.mjs 1.29 kB
packages/preact-transform/dist/signals-transform.umd.js 1.42 kB
packages/preact/dist/signals.js 1.81 kB
packages/preact/dist/signals.mjs 1.75 kB
packages/react-transform/dist/signals-transform.js 7.28 kB
packages/react-transform/dist/signals-transform.mjs 6.47 kB
packages/react-transform/dist/signals-transform.umd.js 7.39 kB
packages/react/dist/signals.js 214 B
packages/react/dist/signals.mjs 165 B
packages/vite-plugin/dist/vite-plugin.js 8.86 kB
packages/vite-plugin/dist/vite-plugin.mjs 7.86 kB

compressed-size-action

Wrap nested object methods returned from createModel so composed models keep action batching semantics without manual action wrappers.
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoviDeCroock JoviDeCroock merged commit 0c65390 into main Mar 28, 2026
6 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-nested-model-actions branch March 28, 2026 09:07
@github-actions github-actions bot mentioned this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants