feat(react-transform-rolldown): add native rolldown plugin#904
Open
JoviDeCroock wants to merge 5 commits intomainfrom
Open
feat(react-transform-rolldown): add native rolldown plugin#904JoviDeCroock wants to merge 5 commits intomainfrom
JoviDeCroock wants to merge 5 commits intomainfrom
Conversation
Port the React Signals transform to Rolldown so users can enable automatic signal subscriptions in Rolldown and Vite Rolldown builds without configuring Babel.
🦋 Changeset detectedLatest commit: f2c8f23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +18.7 kB (+11.73%) Total Size: 178 kB
ℹ️ View Unchanged
|
Pin the Rolldown package to the repo's existing React type versions so TypeScript resolves a single JSX type set and CI linting stays green.
Include prettier with the Rolldown transform package so the ported transform tests can run in CI without relying on unrelated workspace hoisting.
Use an exact React package path in the React 16 CI step so sibling packages with the same prefix are not picked up by Vitest.
Rely on the workspace Vitest setup instead of listing jsdom directly in the Rolldown transform package, while keeping its tests and repo checks passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrated from rolldown/plugins#21
Summary
@preact/signals-react-transform-rolldownpackage with version0.0.0Testing
pnpm --filter @preact/signals-react-transform-rolldown testpnpm build:react-transform-rolldown