Merged
Conversation
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: e730ce1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +16.8 kB (+10.57%) Total Size: 176 kB
ℹ️ View Unchanged
|
43081j
reviewed
Mar 10, 2026
| endpointBase: string; | ||
| } | ||
|
|
||
| export function createClientModuleCode( |
Contributor
There was a problem hiding this comment.
Is it possible to read this file in from disk? So we can get type checking, linting, etc at dev time.
Like read an actual TS file then replace some magic strings with the defaults
Member
Author
There was a problem hiding this comment.
I prefer to do this separately as it would be a large change where we need to transpile ts of this
Clear active sessions on reset and align tests/docs with the remaining event sources after removing console capture.
Keep active sessions alive when clearing buffered events so clients can reuse existing filters across debugging runs.
Avoid exact session object equality so production builds do not fail on createdAt and updatedAt variability across responses.
rschristian
reviewed
Mar 11, 2026
Load the React and Preact transform packages on demand so projects only need the one they use. Document the optional setup and keep TypeScript aligned with the dynamic import support.
JoviDeCroock
force-pushed
the
signals-vite
branch
from
bd81371 to
6017b62
Compare
rschristian
reviewed
Mar 11, 2026
JoviDeCroock
requested review from
developit,
marvinhagemeister and
rschristian
rschristian
approved these changes
Mar 15, 2026
.changeset/thin-moles-smile.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@preact/signals-vite-plugin": minor | |||
Member
There was a problem hiding this comment.
I think this will need a tweak now, I imagine it'll fail to find this when publishing?
Member
Author
There was a problem hiding this comment.
It will initially fail, I will manually publish 0.0.0 and then the minor version will do 0.1.0 - I do have to adjust the package name indeed 😅 I naively just did the package.json
rschristian
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new vite plugin which does several things
Relates to https://x.com/JoviDeC/status/2031404460178833693
I want to apologize in advance for the huge amount of code, I could not have done this in the time it took without the help of GPT5.4
One open question is how to distribute a skill like this.
For the curious, I wrote about this flow in https://jovidecroock.com/blog/llm-signals-debugging