Merged
Conversation
🦋 Changeset detectedLatest commit: b7b288c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
nit, changeset is missing |
marvinhagemeister
approved these changes
Feb 19, 2026
Member
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
LGTM, with changeset added
rschristian
approved these changes
Feb 19, 2026
Member
|
Depending on your definition of "full document", we're still missing the preamble as mentioned here. User will be dropped into quirks mode with our current setup which feels wrong. |
Member
Author
|
@rschristian good point, will add that |
rschristian
approved these changes
Feb 19, 2026
JoviDeCroock
force-pushed
the
chunked-rendering-fixes
branch
from
1763ae1 to
b7b288c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #415
I think we're not complete yet, the client-script can still bug out and we'll need to adjust
Reproduction in https://github.com/jplhomer/preact-react-router - fixes in action at https://github.com/JoviDeCroock/preact-react-router
Technically we also need preactjs/preact#5028 but we can solve that by introducing a faux-node when hydrating by means of
{ nodeType: 1, childNodes: [document.documentElement], firstChild: document.documentElement }