using lsp#ui#vim#output#closepreview() to close preview before open new one#712
Closed
xuanduc987 wants to merge 1 commit into
Closed
using lsp#ui#vim#output#closepreview() to close preview before open new one#712xuanduc987 wants to merge 1 commit into
xuanduc987 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks your contribution. As far as I looked code for little time, current implementation can show hover popup and diagnostics popup both in same time. Using lsp#ui#vim#output#closepreview() closes previous popup. So this change show only one popup. I'm considering how many users want to show both popups. |
Owner
|
Closing for now since we can show multiple popup windows. There is a separate task going on to make this easier. vim-jp/vital.vim#748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
let g:lsp_diagnostics_float_cursor = 1I can't open hover on line with errors.Using
lsp#ui#vim#output#closepreview()to close previous preview window seems to fix it. From reading the code, it seems to be correct to use this function, but I not sure if there are any other reasons for the original code