Diagnostic float: Split event handling flow#1669
Conversation
|
I don't make sure but it this can use merge & pipe like: #1551 (comment) ? |
I think it makes is much harder to understand the logic when we merge events from 3 unrelated sources. This PR main goal is to remote the When we combine unrelated things, it also makes it harder to make changes. Moving to separate definitions of events for each case enables me to actually start fixing things with any level of confidence :) |
As different events actually need to trigger different actions, it is easier to follow the logic when each event has its own sequence of actions. It also reduces the amount of work, as only |CursorMoved| can cause the float to appear. Restore |CursorHold| functionality disabled by ```gitcommit commit 10fac72 Author: suguruwataru <23465321+suguruwataru@users.noreply.github.com> Date: Thu Jan 1 19:09:58 2026 +0800 Stop `CursorHold` events from updating diagnostic floating window (prabirshrestha#1624) Closes prabirshrestha#1620 Co-authored-by: mattn <mattn.jp@gmail.com> ``` It is still nice to have an option of hiding the float when cursor did not move long enough. A subsequent commit adds a configuration option to control this behavior.
52698e9 to
6917243
Compare
|
Maybe I missed your point. I can do it if you insist. But I'll be a little hesitant to do it myself. |
|
@prabirshrestha What do you think about this? |
As different events actually need to trigger different actions, it is easier to follow the logic when each event has its own sequence of actions.
It also reduces the amount of work, as only |CursorMoved| can cause the float to appear.
Restore |CursorHold| functionality disabled by
It is still nice to have an option of hiding the float when cursor did not move long enough. A subsequent commit adds a configuration option to control this behavior.
It is part of a sequence of changes to fix #1510.
Previous change was #1629.
This and subsequent commits in the sequence: 474c656...illia-bobyr:vim-lsp:9372cfc2f69443d5c907e4e59124595f8689160c