Preserve completion doc scroll position#1636
Open
hbarcelos wants to merge 3 commits intoprabirshrestha:masterfrom
Open
Preserve completion doc scroll position#1636hbarcelos wants to merge 3 commits intoprabirshrestha:masterfrom
hbarcelos wants to merge 3 commits intoprabirshrestha:masterfrom
Conversation
Preserve completion doc scroll position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix completion documentation popup scrolling reset in Vim.
The completion docs popup is re-opened on
CompleteChanged; this preserves the existing scroll position (topline) when the popup already exists, so manual scrolling doesn’t jump back to the top.Tested on Vim 9.1 popup windows.
I also noticed that the
concealconfig was somewhat inconsistent, depending on how the user sets it. For reading purposes, it's better thatconcealis always enabled, even when the line in the popover is highlighted.