Fix two issues encountered in Edge browser (#507)#508
Open
dannya wants to merge 2 commits intopqina:masterfrom
Open
Fix two issues encountered in Edge browser (#507)#508dannya wants to merge 2 commits intopqina:masterfrom
dannya wants to merge 2 commits intopqina:masterfrom
Conversation
…ermining if a file has loaded, since in my testing, Edge is presenting a `File` object at this stage, rather than the `Blob` that Chrome etc are presenting (fixes pqina#507). * If `createFileProcessorFunction` is presented with a file object that is not of type `Blob` (such as `File`, as seen in Edge browser), it attempts to iterate over it using `forEach` as if it were an iterable object, however `File` objects do not have a `forEach` method. Resolve this by treating all file object input into this function as though they are a singular, non-iterable object (fixes pqina#507). * Fix comment typo.
Author
|
I've |
dannya
changed the title
!isFile() instead of !(state.file instanceof Blob) when det…
dannya
changed the title
…ince there are no other console.log statements in the project!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ermining if a file has loaded, since in my testing, Edge is presenting a
Fileobject at this stage, rather than theBlobthat Chrome etc are presenting (fixes #507).If
createFileProcessorFunctionis presented with a file object that is not of typeBlob(such asFile, as seen in Edge browser), it attempts to iterate over it usingforEachas if it were an iterable object, howeverFileobjects do not have aforEachmethod. Resolve this by treating all file object input into this function as though they are a singular, non-iterable object (fixes [HAS PR #508] File not uploading in Edge browser, stalls at "Uploading" stage (no percentage) #507).Fix comment typo.