Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bkhadars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
size/L
Contributor
|
/cc @sudeeshjohn please review |
sudeeshjohn
reviewed
Aug 28, 2025
sudeeshjohn
reviewed
Aug 28, 2025
sudeeshjohn
reviewed
Aug 28, 2025
| } | ||
| } else { | ||
| if err = mount("nouuid", bootDev, bootMount); err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
could you please check if "defaults" work for other filesystem types as well ?
sudeeshjohn
reviewed
Aug 28, 2025
sudeeshjohn
reviewed
Aug 28, 2025
sudeeshjohn
reviewed
Aug 28, 2025
| mv /etc/resolv.conf.orig /etc/resolv.conf || true | ||
| touch /.autorelabel | ||
| setfiles -F /etc/selinux/targeted/contexts/files/file_contexts / | ||
| ` |
Contributor
There was a problem hiding this comment.
this is already part of the code
sudeeshjohn
reviewed
Aug 28, 2025
| return err | ||
| } | ||
| if !supported { | ||
| klog.Errorln("to create fedora ova image btrfs support should be available in the kernel]") |
Contributor
There was a problem hiding this comment.
Request to make this little more clear,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #737
Special notes for your reviewer:
**Output/Demonstration
fedora distribution support is added to pvsdm