Add unit and browser tests for network map layers, upgrade deck.gl to 9.3

[amarant]

• Implemented tests for ArrowLayer, ForkLineLayer, ParallelPathLayer, ScatterplotLayerExt, and LineLayer.
• Added screenshot comparison functionality for visual regression testing.
• Created utility functions for rendering layers and setting up test environments.
• Introduced network and geo data creation functions for testing purposes.
• Added browser setup entrypoint for package-level shared initialization.
• Updated App.tsx to utilize large network and geo data for testing.
• Added new test cases for arrow, fork, parallel path, and scatterplot layers to handle large network scenarios.
• Introduced large network and geo data creation functions in network-fixtures.ts.
• Adjusted browser rendering setup to accommodate larger viewport sizes.
• Enhanced logging for current view state in network-map.tsx.
• Updated Vitest configuration for increased viewport dimensions in tests.
• Updated @deck.gl and @luma.gl dependencies to 9.3.0 versions in package.json and network-map-layers/package.json.
• Add Playwright installation step to CI build process
• Add upload step for browser failure screenshots in CI workflows
• Add image approximate comparison in tests
• Add sonar ignore for test fixtures
• Refactor LineLayer deprecated coordinate system enum to use string literals

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• A PR or issue has been opened in all impacted repositories (if any)

What kind of change does this PR introduce?

Add tests for map layers

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sBouzols]

Tests OK in GridSuite app
Some minor comments

[amarant]

You have 10 tests that lack assertions, as pointed out by Sonar, is there a reason for this ?

@NathanDissoubray None of the tests lack assertions, it's just that sonar doesn't understand this is an assertion.

await expectElement(canvas).toMatchScreenshot(...)

[NathanDissoubray]

@amarant there are sonar issues regarding using chains

I'm not sure what this means, but could you take a look at it ?

Concerns have been addressed

[sBouzols]

Where is this file setupBrowserTests.ts ?

[amarant]

it's a leftover of intermediate work, but browser tests didn't need a setup. I will remove it.

[sBouzols]

Could you separate this work into 3 different PRs please:

• DeckGL upgrade to 9.3 and associated code adaptation if needed
• Vitest upgrade to ^4.1.9 and associated code adaptation if needed
• and the last one for vitest UI and Playwright adding and Github workflow adaptation

We think with @SlimaneAmar that it will be easier to follow and merge then.

[amarant]

@SlimaneAmar @sBouzols

Thanks for the suggestion. After reviewing the dependency relationships and the associated code changes, I am not sure splitting this work into three PRs would provide much additional value.
The DeckGL 9.3 upgrade is required because this version introduces the Vitest-specific layer harness used by the new tests:

import { testLayer } from '@deck.gl/test-utils/vitest';

This entry point does not exist in DeckGL 9.2. The only application-code adaptation associated with the DeckGL upgrade is a two-line coordinate-system update:

getProximityFactor(...) {
-    if (this.props.coordinateSystem === COORDINATE_SYSTEM.CARTESIAN) {
+    if (this.props.coordinateSystem === 'cartesian') {
         // Cartesian distance calculation
     }
}

computeAngle(...) {
-    if (props.coordinateSystem === COORDINATE_SYSTEM.CARTESIAN) {
+    if (props.coordinateSystem === 'cartesian') {
         // Cartesian angle calculation
     }
}

DeckGL 9.3 changes coordinate systems from numeric values to string values and recommends using the string constants directly. Apart from these two lines, the DeckGL bump is only there to make the new Vitest layer harness available.
The Vitest upgrade from 4.0.18 to 4.1.9 does not introduce or require any code change. It is simply a dependency bump to keep the testing tool and its related packages up to date:

- "@vitest/coverage-v8": "^4.0.18",
+ "@vitest/coverage-v8": "^4.1.9",

- "vitest": "^4.0.18"
+ "vitest": "^4.1.9"

The Playwright provider, browser configuration, screenshots, tests and workflow adaptations are all parts of the same browser-testing feature.

Consequently, splitting this into three PRs would result in:

1. A dependency upgrade required by the tests, with only a two-line code adaptation.
2. A dependency-only Vitest update with no code adaptation.
3. The actual tests and CI changes that depend on those dependencies.

These would be stacked rather than independent PRs, and each would introduce overlapping package-lock.json changes. For that reason, I think keeping the changes together provides a more coherent and testable unit of work. If the main concern is the review size, a more meaningful split could be unit/lifecycle tests versus browser visual tests and CI.

If useful, I can also explain the dependency relationships and the rationale for keeping these changes together in person.

[sonarqubecloud]

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud