docs: plan for #288 — improved timeout configuration#332
Open
posit-vip-triage[bot] wants to merge 5 commits into
Open
docs: plan for #288 — improved timeout configuration#332posit-vip-triage[bot] wants to merge 5 commits into
posit-vip-triage[bot] wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Preview Links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #288 (planning step).
This PR proposes a plan for centralizing timeout configuration in VIP. The plan introduces a new top-level
[timeouts]section invip.tomlwith semantic per-operation fields (e.g.connect_deploy,workbench_session_start,playwright_mfa_complete,http_request,job_wait), a globalscalemultiplier, and a matchingVIP_TIMEOUT_SCALEenv var so operators on small QA / Marketplaces VMs can dilate every timeout uniformly without editing source.Existing per-section knobs (
ConnectConfig.deploy_timeout,PerformanceConfig.page_load_timeout,PerformanceConfig.download_timeout) keep working unchanged via a precedence rule (per-section override →[timeouts]field → built-in default), so no currentvip.tomlbecomes invalid.The plan also flags three open questions for maintainer input:
playwright_mfa_completeshould opt out of the globalscale(it's a human wait, not a server wait)VIP_TIMEOUT_SCALEDeprecationWarningon the legacyconnect.deploy_timeoutknobMerging this PR will trigger an implementation PR — comment to iterate on the plan first.