Skip to content

Assistant: Remove testModels setting #11187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cameronmpalmer wants to merge 1 commit into from
Closed

Assistant: Remove testModels setting #11187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/vs/workbench/contrib/chat/browser/chatWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,8 +1316,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
} else if (!this.languageModelsService.currentProvider) {
// When Anthropic is the only supported provider, we can use a more specific message.
// TODO: remove this custom handling https://github.com/posit-dev/positron/issues/8301
const hasAdditionalModels = this.configurationService.getValue<boolean>('positron.assistant.testModels') ||
this.configurationService.getValue<string[]>('positron.assistant.enabledProviders')?.length > 0;
const hasAdditionalModels = this.configurationService.getValue<string[]>('positron.assistant.enabledProviders')?.length > 0;

welcomeTitle = localize('positronAssistant.gettingStartedTitle', "Set Up Positron Assistant");
const addLanguageModelMessage = hasAdditionalModels
Expand Down
5 changes: 0 additions & 5 deletions src/vs/workbench/contrib/positronAssistant/browser/positronAssistantService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,6 @@ export class PositronAssistantService extends Disposable implements IPositronAss

getSupportedProviders(): string[] {
const providers = ['anthropic-api', 'copilot'];
const useTestModels = this._configurationService.getValue<boolean>('positron.assistant.testModels');

if (useTestModels) {
providers.push('amazon-bedrock', 'error', 'echo', 'google');
}
return providers;
}

Expand Down
6 changes: 3 additions & 3 deletions test/e2e/fixtures/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
"files.simpleDialog.enable": true,
"positron.importSettings.enable": false,
"positron.assistant.enable": true,
"positron.assistant.testModels": true,
"positron.assistant.enabledProviders": [
"openai-api"
"openai-api",
"echo"
],
"posit.workbench.showWorkbenchFlaskHint": false
}
}
Loading