Remove ORAS manifest delete from merge workflow#557
Merged
Conversation
The OrasManifestDelete command frequently failed when cleaning up the temporary manifest index after a merge. Remove the command and the in-line cleanup step; the temporary index is now left in place and cleaned up out-of-band by the clean.yml workflow (bakery clean temp-registry). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Test Results1 568 tests 1 568 ✅ 8m 31s ⏱️ Results for commit 6c8b7d0. |
bschwedler
approved these changes
Jun 1, 2026
bschwedler
left a comment
bschwedler
left a comment
Contributor
There was a problem hiding this comment.
Is there any reason we would want to keep this around as a standalone CLI command?
Contributor
Author
I can't think of any. It seems like GHCR is straight up incompatible with OCI deletion commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
OrasManifestDeletecommand frequently failed when cleaning up the temporary manifest index after a merge. This removes the command and the in-line cleanup step fromOrasMergeWorkflow.The temporary index is now left in place and cleaned up out-of-band by the
clean.ymlworkflow (bakery clean temp-registry), which each product repo already runs on a schedule.Changes
OrasManifestDeleteclass fromoras.py.OrasMergeWorkflow.run(); the workflow now only creates the temporary index and copies it to destinations.clean.yml.OrasManifestDeleteimport, removedTestOrasManifestDeleteandtest_manifest_delete_with_plain_http, and adjustedtest_execute_success's call-count assertion from 4 → 3.Testing
uv run pytest test/plugins/builtin/oras/→ 43 passeduv run ruff checkon both modified files → all checks passedNotes
With the in-line delete gone, temporary indexes now persist until the cleanup job runs (default: removes those older than 3 days) rather than being deleted immediately after each merge.
🤖 Generated with Claude Code