feat: add usage metrics dashboard (otel version)#7
Conversation
|
[edit] Actually this may be wrong, maybe I just need to make it available in the GH workflow for this extension. |
|
@joshyam-k Sorry for the slow turnaround here — I was making changes to the tracing as I worked on the report. I addressed your feedback though, and I think this version should be good to merge. I'll make any further tracing changes on a new branch. I also addressed those issues on #6, so that should be good for a review. Thanks! |
There was a problem hiding this comment.
This all looks great, thanks! There is an issue with this one though in that I believe CI has to pass cleanly for the extensions list to be updated (what dogfood pulls from to populate the gallery). I'm not sure how we get around that here since the R otelsdk package can't be installed on the connect images. @jonkeane thoughts?
@joshyam-k I can get CI working, maybe just another iteration or two. |
|
@toph-allen oh okay great! will be all good to merge once that's green |
|
Never mind, I was wrong — I fixed the other CI issues and now we're running into the CI issues I originally thought we were hitting in this comment:
I think we should hold this PR open while I update our dev images — IMHO it's actually pretty critical for our Connect dev images to be able to install R's Once that happens, CI here will be able to pass and we can merge this PR. |
|
yes, agreed to keeping it open. let me know if I can be of any help with updating those images! |
|
I thought we had already update those images? Does this "just" need to be bumped for CI to work? Or is there an open issue with adding those dependencies to the dev images still? |
|
@jonkeane I haven't pushed on merging this because it hasn't been affecting my ability to use it, but I think the issue might be that it's being tested across multiple old versions of Connect, and… updating our current dev images doesn't affect the old images used for those versions, right? 🤔 I guess you could argue that for |
Adds a version of the Usage Metrics Dashboard that's wired up to send OTel spans.
Adds GitHub Actions workflows to "release" the extension.
Deployed on Dogfood here