feat(ui): add icons to navigation bar#2300
feat(ui): add icons to navigation bar#2300cdrage wants to merge 1 commit intopodman-desktop:mainfrom
Conversation
|
|
||
| <nav | ||
| class="z-1 w-leftsidebar min-w-leftsidebar shadow-sm flex-col justify-between flex bg-[var(--pd-secondary-nav-bg)] border-[var(--pd-global-nav-bg-border)] border-r-[1px]" | ||
| class="z-1 w-leftsidebar min-w-leftsidebar flex-col justify-between flex transition-all duration-500 ease-in-out bg-[var(--pd-secondary-nav-bg)] border-[var(--pd-global-nav-bg-border)] border-r-[1px]" |
There was a problem hiding this comment.
FYI these changes to shadow-sm is because I noticed that the classes were difference vs our "Preferences navigation".
So this was changed to better reflect how we do it elsewhere: https://github.com/podman-desktop/podman-desktop/blob/64935c23cd6ae83fceeace34d944da2279266cd1/packages/renderer/src/PreferencesNavigation.svelte#L85-L86
### What does this PR do? Some leftover code I had from a while ago, this adds the icons to the navbar similar to the podman desktop settings style. We also upgrade to the newest ui svelte in order to incorporate the "spacing changes" added for preferences. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#2298 ### How to test this PR? Open up bootc and see the new icons on the navbar :) <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
e65b594 to
642307f
Compare
📝 WalkthroughWalkthroughBumps "@podman-desktop/ui-svelte" from 1.21.0 to 1.25.1 and updates the Navigation component to add FontAwesome icons for items, introduce a BootcImageIcon in the header, apply transition classes, and adjust header/layout styling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| <div class="h-full overflow-y-auto" style="margin-bottom:auto"> | ||
| <SettingsNavItem title="Dashboard" icon={faTableCellsLarge} selected={meta.url === '/'} href="/" /> | ||
| <SettingsNavItem title="Images" icon={BootcImageIcon} selected={meta.url.startsWith('/images')} href="/images" /> | ||
| <SettingsNavItem title="Disk Images" icon={faCompactDisc} selected={meta.url.startsWith('/disk-image')} href="/disk-images" /> |
There was a problem hiding this comment.
Should use DiskImageIcon here to match the page.
| <a href="/" title="Navigate to dashboard" class="pt-4 pl-3 px-5 mb-10 flex items-center ml-[4px]"> | ||
| <p class="text-xl font-semibold text-[color:var(--pd-secondary-nav-header-text)]">Bootable Containers</p> | ||
| <a href="/" title="Navigate to dashboard" class="pt-4 px-3 mb-5 flex items-center gap-3"> | ||
| <BootcImageIcon size="28px" solid /> |
There was a problem hiding this comment.
Good as-is, but wondering if we should use the extension icon? i.e. the purple seal icon we use in the main nav? Or even a purple version of this icon.
feat(ui): add icons to navigation bar
What does this PR do?
Some leftover code I had from a while ago, this adds the icons to the
navbar similar to the podman desktop settings style.
We also upgrade to the newest ui svelte in order to incorporate the
"spacing changes" added for preferences.
Screenshot / video of UI
Before:

After:

What issues does this PR fix or reference?
Closes #2298
How to test this PR?
Open up bootc and see the new icons on the navbar :)
Signed-off-by: Charlie Drage charlie@charliedrage.com