Improves error when retrieving app by objectId, Closes #6884#7171
Open
Improves error when retrieving app by objectId, Closes #6884#7171
Conversation
Wraps request.get in getAppRegistrationByObjectId with a try/catch that intercepts 404 responses and throws a friendly error message matching the pattern used by getAppRegistrationByAppId and getAppRegistrationByAppName. Fixes pnp#6884 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
|
Hi @mvanhorn thanks for the PR. |
Author
|
Got it, will comment on the issue first next time. Thanks for the heads up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAppRegistrationByObjectIdnow returns a clear error message when the objectId doesn't match any application, consistent withgetAppRegistrationByAppIdandgetAppRegistrationByAppName.Before:
Resource 'xxx' does not exist or one of its queried reference-property objects are not present.After:
App with objectId 'xxx' not found in Microsoft Entra ID.Changes
src/utils/entraApp.ts: Wrappedrequest.getin try/catch that intercepts 404 responses and throws a descriptive error. Non-404 errors are re-thrown unchanged.src/utils/entraApp.spec.ts: Added test for the 404 error path.Testing
Closes #6884
This contribution was developed with AI assistance (Claude Code).