Updates ci-cd commands to set node version based on SPFx project version. Closes #6717 by Adam-it · Pull Request #6766 · pnp/cli-microsoft365

Adam-it · 2025-06-19T23:10:09Z

milanholemans

Really cool enhancement @Adam-it! This will improve the command a lot.
However, while reviewing, I found a few things we should take a look at first.

src/m365/spfx/commands/project/project-github-workflow-add.ts

src/m365/spfx/commands/project/project-github-workflow-add.spec.ts

src/m365/spfx/commands/SpfxCompatibilityMatrix.ts

src/utils/spfx.ts

src/utils/spfx.spec.ts

Copilot

Pull Request Overview

This pull request updates CI/CD workflow commands to dynamically determine the Node.js version based on the SharePoint Framework (SPFx) project version rather than using a hardcoded version. The PR refactors shared compatibility data into a separate module and adds logic to compute the appropriate Node.js version from version ranges.

Extracts SPFx version compatibility matrix to a shared module
Adds utility function to parse version ranges and determine highest compatible Node.js version
Updates GitHub workflow and Azure DevOps pipeline commands to set Node.js version dynamically

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/utils/spfx.ts	Added utility function to extract highest Node version from semver range
src/utils/spfx.spec.ts	Added test coverage for the new utility function
src/m365/spfx/commands/spfx-doctor.ts	Removed duplicate compatibility matrix, now imports from shared module
src/m365/spfx/commands/project/project-github-workflow-add.ts	Added logic to determine and set Node version based on SPFx project version
src/m365/spfx/commands/project/project-github-workflow-add.spec.ts	Added test coverage for version determination and error handling
src/m365/spfx/commands/project/project-azuredevops-pipeline-add.ts	Added logic to determine and set Node version based on SPFx project version
src/m365/spfx/commands/project/project-azuredevops-pipeline-add.spec.ts	Added test coverage for version determination and error handling
src/m365/spfx/commands/project/DeployWorkflow.ts	Changed default Node version from hardcoded "22.x" to empty string
src/m365/spfx/commands/SpfxCompatibilityMatrix.ts	New shared module containing SPFx compatibility matrix data

src/utils/spfx.spec.ts

src/utils/spfx.ts

Adam-it · 2025-10-18T23:42:02Z

@milanholemans I added the first batch of fixes to your comments that I could do without thinking 😁.
As for the rest, I will look into them ASAP. In order to solve them, I need to remind myself how it works and why it works this way, as after such a time gap, I have no idea why some of the code was written this way 😁

Adam-it · 2025-11-22T23:11:25Z

@milanholemans it took a while, and I do apologize for that. Lately, I have more tasks/work in a day than I can simply manage within 24 hours

milanholemans · 2025-12-15T10:23:12Z

Hi @Adam-it, seems like we ran into merge conflicts again. Could you have a look? I'll try to get it merged ASAP.

Adam-it · 2025-12-15T12:36:51Z

Hi @Adam-it, seems like we ran into merge conflicts again. Could you have a look? I'll try to get it merged ASAP.

I will but after we merge the spfx update commands PR done by Waldek as it will also touch the spfx doctor command which I update 👍

Adam-it · 2026-01-04T00:00:51Z

@milanholemans,
ready 👍

milanholemans

I've had another look, and I think we should recheck a few things before we merge it.

src/m365/spfx/commands/project/project-github-workflow-add.ts

src/m365/spfx/commands/project/project-github-workflow-add.spec.ts

src/m365/spfx/commands/project/project-github-workflow-add.ts

src/m365/spfx/commands/SpfxCompatibilityMatrix.ts

src/utils/spfx.spec.ts

Adam-it · 2026-01-26T08:46:41Z

ready for another round

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

src/m365/spfx/commands/project/project-azuredevops-pipeline-add.spec.ts

src/m365/spfx/commands/project/project-github-workflow-add.ts

milanholemans

We have some progress, but I feel we need to recheck a few things first.

src/m365/spfx/commands/project/project-github-workflow-add.spec.ts

milanholemans · 2026-02-14T22:43:09Z

src/m365/spfx/commands/project/project-github-workflow-add.spec.ts

+    await assert.rejects(command.action(logger, { options: {} } as any),
+      new CommandError('writeFileSync failed'));


Why do we expect this to fail? SPFx v1.21.1 is valid, right?

Here we simulate failure in saving the file not SPFx version validation

src/m365/spfx/commands/project/project-github-workflow-add.spec.ts

milanholemans · 2026-02-14T22:48:53Z

src/m365/spfx/commands/project/project-azuredevops-pipeline-add.spec.ts

+    sinon.stub(fs, 'writeFileSync').throws(new Error('writeFileSync failed'));
+
+    await assert.rejects(command.action(logger, { options: {} } as any),
+      new CommandError('writeFileSync failed'));


Also here, I find it weird that this test should fail. v1.21.1 is a valid SPFx version, right?

Yes it is valid. This tests checks how the command will behave when we simulate and unexpected error in the writeFileSync, so at the very end when we update the pipeline after retrieving the SPFx version and related changes and we want to finish of with saving the file

src/m365/spfx/commands/project/project-azuredevops-pipeline-add.spec.ts

src/utils/spfx.spec.ts

…ion. Closes pnp#6717

Adam-it · 2026-02-22T23:06:19Z

@milanholemans I hope this time I got everything right. Sorry for such a long PR, and thanks for handling all this.

This was referenced Jun 19, 2025

Support Multiple SPFx versions pnp/vscode-viva#514

Open

💡 [Feature]: Update Scaffold CI/CD Workflow action to support multiple SPFx versions pnp/vscode-viva#523

Open

milanholemans self-assigned this Oct 17, 2025

milanholemans requested changes Oct 17, 2025

View reviewed changes

milanholemans marked this pull request as draft October 17, 2025 22:54

milanholemans requested a review from Copilot October 17, 2025 22:54

Copilot AI reviewed Oct 17, 2025

View reviewed changes

src/utils/spfx.spec.ts Outdated Show resolved Hide resolved

src/utils/spfx.ts Outdated Show resolved Hide resolved

src/utils/spfx.ts Show resolved Hide resolved

Adam-it force-pushed the updates-ci-cd-commands-to-support-all-spfx-versions branch from 47d9054 to d6cbe35 Compare October 18, 2025 00:06

Adam-it force-pushed the updates-ci-cd-commands-to-support-all-spfx-versions branch from ebb5e21 to 136ddf6 Compare November 22, 2025 22:04

Adam-it marked this pull request as ready for review November 22, 2025 23:07

milanholemans marked this pull request as draft December 15, 2025 10:23

Adam-it force-pushed the updates-ci-cd-commands-to-support-all-spfx-versions branch from 136ddf6 to e418c6e Compare January 3, 2026 23:56

Adam-it marked this pull request as ready for review January 3, 2026 23:57

Adam-it mentioned this pull request Jan 4, 2026

The spfx ci/cd commands generate wokrflow/pipeline that use gulp for SPFx 1.22.x projects #7091

Open

milanholemans requested changes Jan 4, 2026

View reviewed changes

milanholemans marked this pull request as draft January 4, 2026 20:46

Adam-it force-pushed the updates-ci-cd-commands-to-support-all-spfx-versions branch 2 times, most recently from 74284fb to eb49673 Compare January 26, 2026 08:39

Adam-it marked this pull request as ready for review January 26, 2026 08:46

milanholemans requested a review from Copilot February 14, 2026 22:24

Copilot started reviewing on behalf of milanholemans February 14, 2026 22:24 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

src/m365/spfx/commands/project/project-azuredevops-pipeline-add.spec.ts Outdated Show resolved Hide resolved

src/m365/spfx/commands/project/project-github-workflow-add.ts Show resolved Hide resolved

milanholemans requested changes Feb 14, 2026

View reviewed changes

milanholemans marked this pull request as draft February 14, 2026 23:02

Adam-it added 3 commits February 22, 2026 23:40

Updates ci-cd commands to set node version based on SPFx project vers…

0241b60

…ion. Closes pnp#6717

Updates to address review comments

e9b8b22

Addresses code reviews

833fa4b

Adam-it force-pushed the updates-ci-cd-commands-to-support-all-spfx-versions branch from 992b640 to 833fa4b Compare February 22, 2026 22:40

fixup

8cf4873

Adam-it marked this pull request as ready for review February 22, 2026 23:05

		await assert.rejects(command.action(logger, { options: {} } as any),
		new CommandError('writeFileSync failed'));

Conversation

Adam-it commented Jun 19, 2025

Uh oh!

milanholemans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adam-it commented Oct 18, 2025

Uh oh!

Adam-it commented Nov 22, 2025

Uh oh!

milanholemans commented Dec 15, 2025

Uh oh!

Adam-it commented Dec 15, 2025

Uh oh!

Adam-it commented Jan 4, 2026

Uh oh!

milanholemans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adam-it commented Jan 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

milanholemans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

milanholemans Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Adam-it Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

milanholemans Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Adam-it Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adam-it commented Feb 22, 2026

Uh oh!