Conversation
|
It'd be nice to have the issues not related to nix in a different PR because there's already a lot going on with the nix-related changes |
|
You mean the 12 additions in 6d6f523? |
|
those, and I guess I was expecting a PR that updates nix files to only touch nix files. I'm not a big fan of moving requirements into tools/configure, as it's the requirements for the whole project (both build time and extraction time), rather than the requirements for that script specifically. also, some of the changes to configure seem unrelated as well |
|
The configure changes are required, e.g. passing CLFAGS as an environment variable is needed for the libpapermario package. We should be following this anyway. I don't know how else you solve the unpinned dependency problem without making configure into a pyproject. Are there any actual downsides? |
ethteck
left a comment
ethteck
left a comment
There was a problem hiding this comment.
from our discord convo, theez
|
🚀🚀🚀🚀 This PR matches 4 functions (+0.00%) on |
ethteck
left a comment
ethteck
left a comment
There was a problem hiding this comment.
looks grood, but the configure script seems to be failing the black check
bates64
force-pushed
the
nix-flake
branch
3 times, most recently
from
e8d6117 to
5ccf305
Compare
- `shell.nix` is now `flake.nix` - use `nix develop` instead of `nix-shell` - ELFs can be built with `nix build .#papermario_us` (or any other verison) - Default development shell requires all baseroms - Uses dream2nix to handle Python dependencies, instead of every `nix develop` doing `pip install` which was awful
3 participants
shell.nixis nowflake.nixnix developinstead ofnix-shellnix build .#papermario_us(or any other verison)nix developdoingpip installwhich was awful