Skip to content

Setup crop - #705

Merged
jwboth merged 10 commits into
devfrom
setup-crop
Aug 29, 2026
Merged

Setup crop#705
jwboth merged 10 commits into
devfrom
setup-crop

Conversation

@jwboth

@jwboth jwboth commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

This pull request refactors and improves the crop correction workflow in the application, making the handling of crop corners more robust and user-friendly. The main changes include switching from an ordered list of crop points to named corners throughout the codebase, updating configuration formats, and enhancing the GUI to support interactive crop correction. Additionally, the configuration loading and saving logic is improved for better reliability.

Core logic and configuration changes:

  • The crop assistant (crop_assistant.py) now classifies selected points into named corners (top_left, bottom_left, bottom_right, top_right), making the crop process robust to the order in which points are selected. The configuration output now uses these named corners instead of an ordered list. [1] [2] [3] [4] [5] [6] [7]
  • The configuration files (config.json, config_co2.json) and the configuration loader (curvature.py) are updated to use named corners for the crop region. The loader reconstructs the legacy pts_src as needed for backward compatibility. [1] [2] [3] [4]
  • The deprecated crop method in the curvature correction class is removed, as the new approach supersedes it.

GUI and workflow enhancements:

  • The GUI now includes an interactive "Crop correction" step in the setup sidebar, with contextual help and support for running the crop assistant. [1] [2] [3]
  • The setup workflow and process runner are updated to support the crop correction step, ensuring that configuration changes are saved and reloaded appropriately when running subprocesses. [1] [2] [3] [4] [5] [6]

Bug fixes and minor improvements:

  • Typo fixes in docstrings and improved error/warning messages for configuration loading. [1] [2] [3]

These changes make crop correction more reliable, improve user experience, and ensure the configuration format is consistent and future-proof.

@jwboth
jwboth requested a review from Teggo19 as a code owner August 29, 2026 09:14
@jwboth
jwboth merged commit 294d7c6 into dev Aug 29, 2026
5 checks passed
@jwboth
jwboth deleted the setup-crop branch August 29, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant