Open
Conversation
Using a font instead of custom inline-svg all default dashboard styles are applied to the Cachify icons, too. Convert the current icons into a font using IcoMoon app and adjust the output accordingly. Preserve original SVG files, but do not distribute. Inline WOFF2 to prevent additional requests for most modern browsers.
stklcode
force-pushed
the
feature/iconfont
branch
from
4455dcb to
e4da73e
Compare
stklcode
force-pushed
the
feature/iconfont
branch
from
e4da73e to
e7b57a4
Compare
stklcode
force-pushed
the
feature/iconfont
branch
from
e7b57a4 to
5a08f52
Compare
stklcode
force-pushed
the
feature/iconfont
branch
from
5a08f52 to
e94d99a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a font instead of custom inline-svg all default dashboard styles are applied to the Cachify icons, too.
Convert the current icons into a font using IcoMoon app and adjust the output accordingly. Preserve original SVG files, but do not distribute.
Inline WOFF2 to prevent additional requests for most modern browsers.
This PR contradicts the changes introduces in #64 where we migrated from OpenType font to SVG.
It is true that SVG can be considered superior to icon fonts in various cases, but the native WP icons use the Dashicons icon font and styling from themes, plugins, etc. does not apply to our SVG, i.e. the Cachify icon always has the default grayish color.
So for the sake of consistency I would prefer using the same technology here.
resolves #264 for various dark mode plugins