Apply AriaAttributes to Sunburst chart - #2841
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2823, which added
ariaLabel/ariaLabelledBy/ariaDescribedByto the Pie chart.Sunburstdefaultsroleto'img'but doesn't accept the aria props, so the rendered<svg role="img">has no way to receive an accessible name.SvgWrapperalready forwards these attributes for the other charts (Bar, Line, Radar, Pie, etc.); Sunburst just wasn't passing them through.This wires the same three props from
InnerSunbursttoSvgWrapper, matching the existing charts.packages/sunburst/src/types.ts: add the three optional props toSunburstCommonPropspackages/sunburst/src/Sunburst.tsx: forward them toSvgWrapperpackages/sunburst/tests/Sunburst.test.tsx: assert they reach the root<svg>(same shape as the Radar accessibility test)