Skip to content

When sorting expanded events, do not fail if there is no end attribute set.#307

Open
thet wants to merge 1 commit into
masterfrom
thet-fixes
Open

When sorting expanded events, do not fail if there is no end attribute set.#307
thet wants to merge 1 commit into
masterfrom
thet-fixes

Conversation

@thet

@thet thet commented Jun 6, 2019

Copy link
Copy Markdown
Member

No description provided.

@mister-roboto

Copy link
Copy Markdown

@thet thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@stevepiercy

Copy link
Copy Markdown
Member

@jenkins-plone-org please run jobs

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I have no idea what this fixes, I'd say go ahead and merge it, as I trust you know what you're doing. I'm just getting my feet wet with this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants