Draft
Conversation
ninanoleto
force-pushed
the
storybook-demo
branch
2 times, most recently
from
c9dc48d to
4847935
Compare
stevepiercy
requested changes
Feb 12, 2025
stevepiercy
requested changes
Feb 12, 2025
Contributor
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
The new Makefile commands should be added to the README.md, which also serves as Mockup's contributing guide for developers.
ninanoleto
force-pushed
the
storybook-demo
branch
2 times, most recently
from
261ae2b to
450b5ea
Compare
stevepiercy
reviewed
Feb 13, 2025
.storybook/main.js
Outdated
| ], | ||
| }); | ||
|
|
||
| // TODO: make the mock work |
Contributor
There was a problem hiding this comment.
I was chatting with some Volto folks, and they pointed me to https://6.docs.plone.org/storybook/?path=/story/edit-widgets-object-browser--single-element. I don't know whether any of that can be reused here. Also sometimes Storybook components break, as we don't have a way to test them in CI.
For a fully working demo, visit https://volto.demo.plone.org/, login as admin/admin, edit the page, then insert an image block.
ninanoleto
force-pushed
the
storybook-demo
branch
from
df4c9f9 to
e74cfad
Compare
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.