Treat +html structured MIME suffix as text#6
Open
sabat24 wants to merge 1 commit into
Open
Conversation
application/vnd.live-component+html and other +html vendor types were classified as binary and base64-encoded for route fulfillment, which breaks morphdom in Symfony UX Live Component in-process E2E tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Problem
application/vnd.live-component+html(Symfony UX Live Component) was treated as binary.prepareFulfillOptions()base64-encoded the HTML body, so morphdom never updated the DOM during in-process Playwright intercept.Solution
Extend structured suffix handling (
+json,+xml) to+html, matching on the base MIME type before; charset=…parameters.Tests
testIsBinaryContentTypeTreatsStructuredHtmlSuffixAsTextaddedtestPrepareFulfillOptionsLeavesLiveComponentHtmlAsPlainTextadded