Fall back to postDataBuffer() when postData() is null#4
Open
sabat24 wants to merge 1 commit into
Open
Conversation
…is null Playwright returns null from postData() for multipart/form-data while the raw body remains available via postDataBuffer(). Without the fallback, intercepted Live Component actions receive an empty request body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Problem
In-process Playwright intercept passes multipart
FormData(e.g. Symfony UX Live Component actions) withpostData() === nullwhile the body is available viapostDataBuffer().RequestConverterskipped parsing entirely, so the kernel received an empty POST.Solution
Fall back to
postDataBuffer()whenpostData()is null before content-type parsing.Tests
testMultipartFormDataFallsBackToPostDataBufferWhenPostDataIsNulladded