Switch to Observability Pipeline endpoints for querying metrics

[romainneutron]

This PR uses observability pipeline for metrics commands

It fixes OBS-1224

This deprecates the interval option that is not supported on observability pipelines, and the metrics:curl command that is not supported by observability pipelines

[Copilot]

Pull Request Overview

This PR modernizes the metrics command system by switching from the legacy metrics API to the new Observability Pipeline endpoints. The changes involve significant refactoring of the metrics command architecture and data model.

• Replaces the legacy metrics API with observability pipeline endpoints for querying metrics
• Introduces new model classes with type-safe enums and structured data handling
• Deprecates the interval option and metrics:curl command as they are not supported by the new pipeline

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Model/ProjectRoles.php	Style improvement for consistent comparison operator placement
src/Model/Metrics/TimeSpec.php	Removes interval parameter from TimeSpec constructor and related methods
src/Model/Metrics/SourceFieldPercentage.php	Adds new model for percentage calculations with value and limit fields
src/Model/Metrics/SourceField.php	Adds new model for source field definitions with metric kind, aggregation, and mountpoint
src/Model/Metrics/Sketch.php	Removes deprecated Sketch class that handled old API response format
src/Model/Metrics/Query.php	Complete refactor to support new observability pipeline query format
src/Model/Metrics/MetricKind.php	Adds enum for metric types and API constants for type and aggregation mapping
src/Model/Metrics/Format.php	Adds new enum-based formatting system with color-coded warning thresholds
src/Model/Metrics/Field.php	Simplifies Field class to use new format and source field system
src/Model/Metrics/Aggregation.php	Adds enum for aggregation types (avg, max)
src/Command/Metrics/MetricsCommandBase.php	Removes legacy base class with old API integration
src/Command/Metrics/MemCommand.php	Updates to use new AbstractMetricsCommandBase and new model classes
src/Command/Metrics/DiskUsageCommand.php	Updates to use new AbstractMetricsCommandBase and new model classes
src/Command/Metrics/CurlCommand.php	Deprecates command with warning message as it's not supported by new pipeline
src/Command/Metrics/CpuCommand.php	Updates to use new AbstractMetricsCommandBase and new model classes
src/Command/Metrics/AllMetricsCommand.php	Updates to use new AbstractMetricsCommandBase and comprehensive field mapping
src/Command/Metrics/AbstractMetricsCommandBase.php	Adds new base class with observability pipeline integration
.php-cs-fixer.dist.php	Adds rule to remove unused imports for better code quality

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pjcdawkins]

Noting:

There are some changes here that will need to be communicated clearly in the changelog. I believe these are minor enough changes that they would be unlikely to break a dependent script and so they are warranted, particularly when accounting for the performance and other gains the new API brings.

• exposing router by default
• no longer exposing ---internal---storage (at least by default, perhaps entirely), although this was not intentionally exposed before
• displaying inodes columns by default in the metrics command (though the first 5 columns are the same, and the other commands' default columns are the same)
• deprecating the --interval option, as you said (the default interval displayed changes from 2 mins to 1)

cc @akalipetis