Implement per-size-class lock sharding to reduce contention#120
Open
Implement per-size-class lock sharding to reduce contention#120
Conversation
- Replace single _miniheapLock with per-size-class _miniheapLocks array - Add separate _largeAllocLock for large allocations (sizeClass == -1) - Add _arenaLock to protect shared arena/allocator state - Add AllLocksGuard RAII class for acquiring all locks in consistent order - Make _miniheapCount atomic for safe access under different locks - Update freeFor() to use per-size-class locks with proper ordering - Defer flushBinLocked() to meshing cycle to avoid lock ordering issues - Update mallctl(), getSize(), okToProceed() for new lock structure Lock ordering: arena → large → sizeClass[0..N-1] This reduces lock contention in multi-threaded workloads by allowing concurrent operations on different size classes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Member
|
@bpowers is this still in progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock ordering: arena → large → sizeClass[0..N-1]
This idea is that this can reduce lock contention in multi-threaded workloads by allowing concurrent operations on different size classes.