Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey everyone,
This proposal simply uses github actions to build the docker image and push it to dockerhub for arm64 and amd64 architectures when someone push something to master.
I've written this for myself as i wanted to run this project on a Raspberry pi v3 Model B so a docker image for the architecture arm64 was needed and the only official image I found (https://github.com/pinterest/snappass/pkgs/container/snappass%2Fsnappass/versions) wasn't suitable for my arch.
I think having an official build on dockerhub could please any user of this project :)
When merging this, you should create a dockerhub account and a free "read,write,delete" authentication key.
After that you just have to configure the secrets here for things to work
I've only followed instructions and examples found here https://github.com/docker/build-push-action
So, of course, there is room for improvement, with, for example a better tagging logic than just having a "latest" version.
Have a nice day
PS: I would fancy having a working build process for armv7 for running on older Rapsberry Pi versions for example. But i'm not planning to work it.
I've seen in the github actions logs when configuring for "linux/arm/v7" that the "cryptography" python library is causing an issue in the build process.