Add support for adding a future into a dispatch group#19
Open
Adlai-Holler wants to merge 2 commits intopinterest:masterfrom
Open
Add support for adding a future into a dispatch group#19Adlai-Holler wants to merge 2 commits intopinterest:masterfrom
Adlai-Holler wants to merge 2 commits intopinterest:masterfrom
Conversation
Collaborator
|
@garrettmoon - Do you think we should merge this? Chris was requested for review but I think someone else needs to commandeer it |
garrettmoon
reviewed
Mar 22, 2019
| * leave when the future completes. If the future | ||
| * is already completed, this method has no effect. | ||
| */ | ||
| - (void)addToDispatchGroup:(dispatch_group_t)dispatchGroup; |
Contributor
There was a problem hiding this comment.
I wonder if this is the best way to expose the composite future feature you're suggesting?
Separately, I think it would be more PINFuture-y to have this in a category and import it below?
Contributor
|
No need to commandeer, I'm happy to review (sorry this took me so long to look at, my notification queue fell off the first page :( ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be useful when using multiple futures for one composite operation.