Optimize sidebar PR status rerenders#2862
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
SidebarThreadPrStatusButtonchild component.SidebarProjectThreadListandSidebarThreadRow, so git target updates do not invalidate the whole thread row.react-scan-recordings/before-sidebar-git-status.webmreact-scan-recordings/after-sidebar-git-status.webmWhy
React Doctor and a manual pass identified
apps/web/src/components/Sidebar.tsxas a hot path. Each branch thread row owned git-status/project-cwd subscription state, so git target/status changes could rerender the full row. Keeping that subscription in the tiny PR-status child limits the rerender surface to the indicator area.React Scan was enabled during the recordings. The before recording shows
SidebarThreadRowhighlights during isolated git-target cwd updates; the after recording shows the same updates no longer highlighting the full rows.UI Changes
No intended visual UI change.
Before/after React Scan recordings are committed in this PR:
react-scan-recordings/before-sidebar-git-status.webmreact-scan-recordings/after-sidebar-git-status.webmChecklist
Verification:
npx -y react-doctor@latest apps/web --json --offline --fail-on none(initial full scan: score 46/Critical; hot files includedSidebar.tsx,ChatView.tsx,CommandPalette.tsx)npx -y react-doctor@latest apps/web --diff main --json --offline --fail-on none(diff scan: score 89/Great on changed file; existing Sidebar diagnostics remain)bun fmtbun lint(passes; existing warnings emitted)bun typecheckNote
Extract PR status rendering into dedicated
SidebarThreadPrStatusButtoncomponent to reduce rerendersSidebarThreadRowinto a newSidebarThreadPrStatusButtoncomponent in Sidebar.tsxprojectCwdfrom the store viaenvironmentId/projectId, removing the need to passprojectCwddown throughSidebarProjectItem→SidebarProjectThreadList→SidebarThreadRowthread.branchis non-null, scoping re-renders to threads with active branchesreact-scan-recordings/to validate the rerender reductionMacroscope summarized de766ba.