fix: check Linux platform before macOS in user agent detection #2860
+1
−2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -377,10 +377,10 @@ const mobileEndorsementRows = [ | |
| function detectPlatform(): Platform | null { | ||
| const ua = navigator.userAgent; | ||
| if (/Win/i.test(ua)) return { os: "win", label: "Download for Windows" }; | ||
| if (/Linux/i.test(ua)) return { os: "linux", label: "Download for Linux" }; | ||
| if (/Mac/i.test(ua)) { | ||
| return { os: "mac", label: "Download for macOS", arch: "arm64" }; | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
|
|
@@ -548,7 +548,6 @@ const mobileEndorsementRows = [ | |
| :global([data-platform="mac"]) .dl-icon--apple { display: block; } | ||
| :global([data-platform="win"]) .dl-icon--windows { display: block; } | ||
| :global([data-platform="linux"]) .dl-icon--linux { display: block; } | ||
|
Contributor
There was a problem hiding this comment. Removed CSS fallback leaves default state without iconMedium Severity The   Reviewed by Cursor Bugbot for commit 7a1b209. Configure here. |
||
|
|
||
| /* Floating harness marks */ | ||
| .hero-float { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
pages/index.astro:548The removed CSS fallback
:global(:not([data-platform])) .dl-icon--apple { display: block; }causes the download buttons to show the hardcoded macOS label text with no icon during page load (before JS runs) or permanently for unrecognized user agents. The icon only appears afterdetectPlatform()executes and setsdata-platform, creating a flash of unstyled content for all users.:global([data-platform="mac"]) .dl-icon--apple { display: block; } :global([data-platform="win"]) .dl-icon--windows { display: block; } :global([data-platform="linux"]) .dl-icon--linux { display: block; } + :global(:not([data-platform])) .dl-icon--apple { display: block; }🤖 Copy this AI Prompt to have your agent fix this: